fix(requirements-txt-fixer): keep --index-url before --extra-index-url#1241
Closed
LouisLau-art wants to merge 2 commits intopre-commit:mainfrom
Closed
fix(requirements-txt-fixer): keep --index-url before --extra-index-url#1241LouisLau-art wants to merge 2 commits intopre-commit:mainfrom
LouisLau-art wants to merge 2 commits intopre-commit:mainfrom
Conversation
asottile
reviewed
Feb 12, 2026
Member
asottile
left a comment
asottile
left a comment
There was a problem hiding this comment.
this doesn't handle -i and -e or whatever the short option is
Comment on lines
+16
to
+19
| _SPECIAL_ORDER = { | ||
| b'--index-url': 0, | ||
| b'--extra-index-url': 1, | ||
| } |
Member
There was a problem hiding this comment.
there's not really any reason to make this a constant -- just adds unnecessary indirection and makes the code harder to understand
Author
|
Good catch — updated to normalize and / so they get the same ordering, and added integration tests for both forms. |
Author
|
Follow-up (previous comment lost formatting): normalized -i and --index-url=... / --extra-index-url=... forms, with integration tests. |
Member
|
so I think that this is insufficient -- it doesn't handle (for instance) but also I can't accept ai generated code -- and this is clearly 100% llm generated and responses |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #612.
requirements-txt-fixersorts entries by name, which causes--extra-index-urlto be placed before--index-url. Pip processes these options in order, and this ordering can change behavior.This adds a small sort special-case so
--index-urlis always ordered before--extra-index-url, and includes a regression test.Test plan:
python -m pytest -q tests/requirements_txt_fixer_test.py